-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Autofill password import] Misc fixes #1184
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for content-scope-scripts ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
dbajpeyi
changed the title
fix: supported path
[Autofill password import] Fix supported path
Oct 31, 2024
Temporary Branch UpdateThe temporary branch has been updated with the latest changes. Below are the details:
Please use the above install command to update to the latest version. |
[Beta] Generated file diffTime updated: Fri, 01 Nov 2024 14:13:46 GMT Android
File has changed Integration
File has changed |
dbajpeyi
force-pushed
the
dbajpeyi/fix/supported-paths
branch
from
October 31, 2024 17:22
1058d41
to
b079299
Compare
dbajpeyi
changed the title
[Autofill password import] Fix supported path
[Autofill password import] Misc fixes
Oct 31, 2024
dbajpeyi
force-pushed
the
dbajpeyi/fix/supported-paths
branch
5 times, most recently
from
November 1, 2024 12:36
297ad13
to
11e20f0
Compare
dbajpeyi
force-pushed
the
dbajpeyi/fix/supported-paths
branch
from
November 1, 2024 13:15
11e20f0
to
b3ade5c
Compare
dbajpeyi
force-pushed
the
dbajpeyi/fix/supported-paths
branch
from
November 1, 2024 14:12
dd502ec
to
7a69964
Compare
dbajpeyi
force-pushed
the
dbajpeyi/fix/supported-paths
branch
from
November 4, 2024 13:12
65dac43
to
38f843d
Compare
…content-scope-scripts into dbajpeyi/fix/supported-paths
dbajpeyi
force-pushed
the
dbajpeyi/fix/supported-paths
branch
from
November 4, 2024 13:30
0afb993
to
100aa6b
Compare
dbajpeyi
force-pushed
the
dbajpeyi/fix/supported-paths
branch
2 times, most recently
from
November 5, 2024 15:19
3b3820d
to
99a99cb
Compare
dbajpeyi
force-pushed
the
dbajpeyi/fix/supported-paths
branch
from
November 5, 2024 15:32
fc27d55
to
da4ccee
Compare
dbajpeyi
force-pushed
the
dbajpeyi/fix/supported-paths
branch
2 times, most recently
from
November 7, 2024 14:23
60ee716
to
0e5c16f
Compare
dbajpeyi
force-pushed
the
dbajpeyi/fix/supported-paths
branch
from
November 7, 2024 14:51
0e5c16f
to
12b3e53
Compare
jonathanKingston
approved these changes
Nov 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Asana Task/Github Issue: https://app.asana.com/0/1205996472158114/1208671198302487/f
Description
indexOf
byincludes
, however I replaced the functionality 😄Original PR: [Google password manager] Android isolated module for password import #1157. This was causing login to break, and also causing other animations to break.
scrollIntoView
fails if the layout is not fully rendered (edge case).Testing Steps
feature/craig/autofill_gpm_ui_to_launch_from_password_manager
) with the confighttps://jsonblob.com/api/1301563859532636160
Checklist
Please tick all that apply: